[webkit-reviews] review granted: [Bug 219975] [macOS] Use low-power audio buffer sizes for more output devices : [Attachment 416392] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 219975: [macOS] Use low-power audio buffer sizes for more output devices
https://bugs.webkit.org/show_bug.cgi?id=219975

Attachment 416392: Patch

https://bugs.webkit.org/attachment.cgi?id=416392&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 416392
  --> https://bugs.webkit.org/attachment.cgi?id=416392
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416392&action=review

> Source/WebCore/platform/audio/AudioHardwareListener.cpp:42
> +    m_supportedBufferSizes = { 32, 4096 };

Can you initialize this in the header?

> Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:72
> +	   return { 0, 0 };

Wouldn't `return { }` do the same?

> Source/WebCore/platform/audio/mac/AudioHardwareListenerMac.cpp:84
> +	   return { 0, 0 };

Ditto.