[webkit-reviews] review granted: [Bug 219962] [LFC][IFC] Add fast path vertical alignment for non-stretchy, baseline aligned atomic inline level boxes : [Attachment 416385] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 16 23:27:08 PST 2020


Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 219962: [LFC][IFC] Add fast path vertical alignment for non-stretchy,
baseline aligned atomic inline level boxes
https://bugs.webkit.org/show_bug.cgi?id=219962

Attachment 416385: Patch

https://bugs.webkit.org/attachment.cgi?id=416385&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 416385
  --> https://bugs.webkit.org/attachment.cgi?id=416385
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416385&action=review

>
Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:345
> -void
LineBoxBuilder::computeLineBoxHeightAndalignInlineLevelBoxesVertically(LineBox&
lineBox)
> +void
LineBoxBuilder::computeLineBoxHeightAndAlignInlineLevelBoxesVertically(LineBox&
lineBox)

The important fix!


More information about the webkit-reviews mailing list