[webkit-reviews] review granted: [Bug 219510] Web Inspector: REGRESSION(r266467): viewing a WebSocket created before Web Inspector was opened doesn't show any message frames : [Attachment 416367] Patch v1.0

[bugzilla-daemon at webkit.org]

BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 219510: Web Inspector: REGRESSION(r266467): viewing a WebSocket created
before Web Inspector was opened doesn't show any message frames
https://bugs.webkit.org/show_bug.cgi?id=219510

Attachment 416367: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=416367&action=review




--- Comment #3 from BJ Burg <bburg at apple.com> ---
Comment on attachment 416367
  --> https://bugs.webkit.org/attachment.cgi?id=416367
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=416367&action=review

LGTM, let's wait for Youenn to take a peek too.

> Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.h:163
> +    // Dummy implementation of inspector related APIs.

Comment is probably not needed.