[webkit-reviews] review granted: [Bug 219771] Make MixedContentChecker stateless : [Attachment 416120] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 219771: Make MixedContentChecker stateless
https://bugs.webkit.org/show_bug.cgi?id=219771

Attachment 416120: Patch

https://bugs.webkit.org/attachment.cgi?id=416120&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 416120
  --> https://bugs.webkit.org/attachment.cgi?id=416120
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416120&action=review

> Source/WebCore/Modules/websockets/WorkerThreadableWebSocketChannel.cpp:413
>	   if (document.frame()) {

if (auto* frame = document.frame())

> Source/WebCore/loader/DocumentThreadableLoader.cpp:593
>      if (m_document.frame()) {

if (auto* frame = m_document.frame())

> Source/WebCore/loader/MixedContentChecker.cpp:59
> +    frame.document()->addConsoleMessage(MessageSource::Security,
MessageLevel::Warning, message);

Let's null check the document just because we can.

> Source/WebCore/loader/MixedContentChecker.h:-69
> -    Frame& m_frame;

Nice.