[webkit-reviews] review denied: [Bug 219947] Make FontCascade::CodePath an enum class : [Attachment 416338] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 219947: Make FontCascade::CodePath an enum class
https://bugs.webkit.org/show_bug.cgi?id=219947

Attachment 416338: Patch

https://bugs.webkit.org/attachment.cgi?id=416338&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 416338
  --> https://bugs.webkit.org/attachment.cgi?id=416338
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416338&action=review

> Source/WebKit/ChangeLog:11
> +2020-12-16  Rob Buis  <rbuis at igalia.com>

Double change log entry.

> Source/WebCore/platform/graphics/FontCascade.h:-192
> -    enum CodePath { Auto, Simple, Complex, SimpleWithGlyphOverflow };

This should probably remain a nested enum.
FontCascade::CodePath::Auto