[webkit-reviews] review granted: [Bug 219930] GamepadButton.prototype is missing 'touched' attribute : [Attachment 416344] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted frankolivier at apple.com's request for
review:
Bug 219930: GamepadButton.prototype is missing 'touched' attribute
https://bugs.webkit.org/show_bug.cgi?id=219930

Attachment 416344: Patch

https://bugs.webkit.org/attachment.cgi?id=416344&action=review




--- Comment #2 from Dean Jackson <dino at apple.com> ---
Comment on attachment 416344
  --> https://bugs.webkit.org/attachment.cgi?id=416344
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416344&action=review

> Source/WebCore/ChangeLog:8
> +	   No new tests (OOPS!).

Please remove this line. You don't need to list a new test since you've
modified an existing one.

> Source/WebCore/Modules/gamepad/GamepadButton.cpp:50
> +    If the button is capable of detecting touch, this property MUST be true
if the button is currently being touched, and false otherwise. If the button is
not capable of detecting touch and is capable of reporting an analog value,
this property MUST be true if the value property is greater than 0, and false
if the value is 0. If the button is not capable of detecting touch and can only
report a digital value, this property MUST mirror the pressed attribute.

Please wrap this line.

Also, I think we need to add a comment on the implementation  e.g.

FIXME: Update if/when we can support touches on a controller.