[webkit-reviews] review granted: [Bug 219875] [macOS] Adjust date input placeholder color based on specified text color : [Attachment 416197] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Aditya Keerthi <akeerthi at apple.com>'s
request for review:
Bug 219875: [macOS] Adjust date input placeholder color based on specified text
color
https://bugs.webkit.org/show_bug.cgi?id=219875

Attachment 416197: Patch

https://bugs.webkit.org/attachment.cgi?id=416197&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 416197
  --> https://bugs.webkit.org/attachment.cgi?id=416197
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416197&action=review

Really great changes!

> LayoutTests/ChangeLog:12
> +	   *
fast/forms/date/date-editable-components/date-editable-components-placeholder-c
olor-expected-mismatch.html: Added.

It’s a little disappointing when we can only create a mismatch test, since
there are so many ways for such tests to pass (false negative).

Can we make a reference test, carefully choosing colors so the placeholder text
can be reproduced with some other mechanism. Or is that impractical?