[webkit-reviews] review denied: [Bug 218093] [css-logical] Implement logical border-radius : [Attachment 416234] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 09:49:39 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has denied zsun at igalia.com's
request for review:
Bug 218093: [css-logical] Implement logical border-radius
https://bugs.webkit.org/show_bug.cgi?id=218093

Attachment 416234: Patch

https://bugs.webkit.org/attachment.cgi?id=416234&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 416234
  --> https://bugs.webkit.org/attachment.cgi?id=416234
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416234&action=review

> Source/WebCore/css/CSSProperty.cpp:175
> +    case CSSPropertyBorderStartStartRadius: {
> +	   return resolveToPhysicalProperty(direction, writingMode,
LogicalRadiusCorner::StartStart, borderRadiusShorthand());
> +    }
> +    case CSSPropertyBorderStartEndRadius: {
> +	   return resolveToPhysicalProperty(direction, writingMode,
LogicalRadiusCorner::StartEnd, borderRadiusShorthand());
> +    }
> +    case CSSPropertyBorderEndStartRadius: {
> +	   return resolveToPhysicalProperty(direction, writingMode,
LogicalRadiusCorner::EndStart, borderRadiusShorthand());
> +    }
> +    case CSSPropertyBorderEndEndRadius: {
> +	   return resolveToPhysicalProperty(direction, writingMode,
LogicalRadiusCorner::EndEnd, borderRadiusShorthand());
> +    }

No need for braces on these.

>> Source/WebCore/platform/text/WritingMode.h:132
>> +enum class LogicalRadiusCorner : uint8_t {
> 
> In the future there might be more properties referencing corners, other than
border radius.
> So it may be better to name the enums like LogicalBoxCorner and BoxCorner.
> Seems I missed this in the Chromium review...

I concur. See BoxSide and LogicalBoxSide.

> Source/WebCore/platform/text/WritingMode.h:187
> +inline RadiusCorner mapLogicalRadiusCornerToPhysicalRadiusCorner(TextFlow
textflow, WritingMode writingMode, LogicalRadiusCorner logicalRadiusCorner)

This can be called mapLogicalCornerToPhysicalCorner()


More information about the webkit-reviews mailing list