[webkit-reviews] review granted: [Bug 219809] [GPUProcess] Crash under AudioDestinationCocoa::setIsPlaying(bool) : [Attachment 416216] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219809: [GPUProcess] Crash under AudioDestinationCocoa::setIsPlaying(bool)
https://bugs.webkit.org/show_bug.cgi?id=219809

Attachment 416216: Patch

https://bugs.webkit.org/attachment.cgi?id=416216&action=review




--- Comment #16 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 416216
  --> https://bugs.webkit.org/attachment.cgi?id=416216
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416216&action=review

> Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.h:48
>      explicit DefaultAudioDestinationNode(BaseAudioContext&,
Optional<float>);

No need for explicit

> Source/WebCore/platform/audio/AudioDestination.h:79
> +    void callRenderCallback(AudioBus* sourceBus, AudioBus* destinationBus,
size_t framesToProcess, const AudioIOPosition& outputPosition)

Can be moved outside of the class declaration.