[webkit-reviews] review granted: [Bug 219848] [WASM-References] Add support for memory.fill : [Attachment 416226] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 15 01:54:46 PST 2020

Yusuke Suzuki <ysuzuki at apple.com> has granted Dmitry <dbezhetskov at igalia.com>'s
request for review:
Bug 219848: [WASM-References] Add support for memory.fill

Attachment 416226: Patch


--- Comment #6 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416226
  --> https://bugs.webkit.org/attachment.cgi?id=416226

View in context: https://bugs.webkit.org/attachment.cgi?id=416226&action=review

r=me with comment.

> Source/JavaScriptCore/wasm/WasmOperations.cpp:641
> +JSC_DEFINE_JIT_OPERATION(operationWasmMemoryFill, bool, (Instance* instance,
uint32_t dstAddress, int32_t targetValue, uint32_t count))

Change `int32_t targetValue` to `uint32_t`.

> Source/JavaScriptCore/wasm/WasmOperations.h:64
> +JSC_DECLARE_JIT_OPERATION(operationWasmMemoryFill, bool, (Instance*,
uint32_t dstAddress, int32_t targetValue, uint32_t count));


More information about the webkit-reviews mailing list