[webkit-reviews] review denied: [Bug 219595] [WASM-References] Add support for type annotated select : [Attachment 416143] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 17:58:27 PST 2020


Yusuke Suzuki <ysuzuki at apple.com> has denied Dmitry <dbezhetskov at igalia.com>'s
request for review:
Bug 219595: [WASM-References] Add support for type annotated select
https://bugs.webkit.org/show_bug.cgi?id=219595

Attachment 416143: Patch

https://bugs.webkit.org/attachment.cgi?id=416143&action=review




--- Comment #7 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416143
  --> https://bugs.webkit.org/attachment.cgi?id=416143
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416143&action=review

> Source/JavaScriptCore/wasm/WasmFunctionParser.h:652
> +	   m_expressionStack.constructAndAppend(zero.type(), result);

Using immediates.targetType is better for future extension?

> Source/JavaScriptCore/wasm/wasm.json:48
> +	   "annotated_select":	  { "category": "control",    "value":	28,
"return": ["prev"],			    "parameter": ["any", "prev",
"bool"],	"immediate": [{"name": "value_type",	 "type":
"value_type"}], 					   "description": "the
same as just select but with a value type immediate" },

https://webassembly.github.io/reference-types/core/binary/instructions.html#par
ametric-instructions is showing `��������  ��∗:������(��������������)`, but it looks like this
definition is not that one.
Can you fix it? br_table's definition would be useful to fix it.

> JSTests/wasm/wasm.json:48
> +	   "annotated_select":	  { "category": "control",    "value":	28,
"return": ["prev"],			    "parameter": ["any", "prev",
"bool"],	"immediate": [{"name": "value_type",	 "type":
"value_type"}], 					   "description": "the
same as just select but with a value type immediate" },

Ditto.


More information about the webkit-reviews mailing list