[webkit-reviews] review granted: [Bug 219881] Get more informatiton from assertion when uidna_openUTS46 fails : [Attachment 416214] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 17:25:08 PST 2020


Alexey Proskuryakov <ap at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 219881: Get more informatiton from assertion when uidna_openUTS46 fails
https://bugs.webkit.org/show_bug.cgi?id=219881

Attachment 416214: Patch

https://bugs.webkit.org/attachment.cgi?id=416214&action=review




--- Comment #4 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 416214
  --> https://bugs.webkit.org/attachment.cgi?id=416214
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416214&action=review

> Source/WTF/wtf/URLParser.cpp:2864
> +	       RELEASE_ASSERT(error == U_MEMORY_ALLOCATION_ERROR);

May be worth logging the error to system log. It's hard to imagine any other
reason for the failure, but it's hard to run out of address space, too.


More information about the webkit-reviews mailing list