[webkit-reviews] review granted: [Bug 219867] [GPUProcess] Crash in SharedRingBufferStorage::setStorage() under GuardMalloc : [Attachment 416185] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219867: [GPUProcess] Crash in SharedRingBufferStorage::setStorage() under
GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=219867

Attachment 416185: Patch

https://bugs.webkit.org/attachment.cgi?id=416185&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 416185
  --> https://bugs.webkit.org/attachment.cgi?id=416185
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416185&action=review

> Source/WebKit/GPUProcess/media/RemoteAudioSourceProviderProxy.cpp:64
> +    auto ringBuffer =
makeUniqueRef<CARingBuffer>(makeUniqueRef<SharedRingBufferStorage>([this,
protectedThis = makeRef(*this)](SharedMemory* memory) mutable {
> +	   storageChanged(memory);
> +    }));

I might have written:

    protectedThis->storageChanged(memory);

And then not captured "this".