[webkit-reviews] review granted: [Bug 219829] REGRESSION (r259137): Clip-path rendering regression when element contains transformed child : [Attachment 416110] Patch

[bugzilla-daemon at webkit.org]

Said Abou-Hallawa <sabouhallawa at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 219829: REGRESSION (r259137): Clip-path rendering regression when element
contains transformed child
https://bugs.webkit.org/show_bug.cgi?id=219829

Attachment 416110: Patch

https://bugs.webkit.org/attachment.cgi?id=416110&action=review




--- Comment #5 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 416110
  --> https://bugs.webkit.org/attachment.cgi?id=416110
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416110&action=review

> Source/WebCore/rendering/RenderLayer.cpp:-4514
> -    if (!rootRelativeBounds)
> -	   rootRelativeBounds = calculateLayerBounds(paintingInfo.rootLayer,
offsetFromRoot, { });
> -

RenderLayer::setupFilters() has similar calculations. And it looks we used to
call calculateLayerBounds() only once if both clip-path and filter are applied.
Now we are going to call calculateLayerBounds() twice but with different
arguments. Do we need to do the same changes in RenderLayer::setupFilters()? Do
we need to remove the variable "Optional<LayoutRect> rootRelativeBounds;" from
RenderLayer::paintLayerContents() since it won't be shared anymore between the
clip-path and the filter.

> LayoutTests/css3/masking/clip-path-overflow-hidden-bounds-expected.html:22
> +			<path d="M0,0 L100,0 L100,100 L0,100 L0,0 z"/>

Weird indentation.

> LayoutTests/css3/masking/clip-path-overflow-hidden-bounds.html:29
> +			<path d="M0,0 L100,0 L100,100 L0,100 L0,0 z"/>

Ditto.