[webkit-reviews] review denied: [Bug 219853] Remove FrameLoader::cancelAndClear : [Attachment 416154] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 14 11:56:11 PST 2020
Alex Christensen <achristensen at apple.com> has denied Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 219853: Remove FrameLoader::cancelAndClear
https://bugs.webkit.org/show_bug.cgi?id=219853
Attachment 416154: Patch
https://bugs.webkit.org/attachment.cgi?id=416154&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 416154
--> https://bugs.webkit.org/attachment.cgi?id=416154
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416154&action=review
> Source/WebCore/page/Frame.h:340
> + FrameLoader* m_loader;
We don't want to increase the storage of raw pointers. This is how
use-after-free bugs arise.
More information about the webkit-reviews
mailing list