[webkit-reviews] review granted: [Bug 219857] [Media in GPU Process][MSE] WebM source buffer parser is not enabled : [Attachment 416175] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 219857: [Media in GPU Process][MSE] WebM source buffer parser is not
enabled
https://bugs.webkit.org/show_bug.cgi?id=219857

Attachment 416175: Patch

https://bugs.webkit.org/attachment.cgi?id=416175&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 416175
  --> https://bugs.webkit.org/attachment.cgi?id=416175
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416175&action=review

> Source/WebCore/platform/graphics/MediaSourcePrivate.h:57
> +    virtual AddStatus addSourceBuffer(const ContentType&, bool
webMParserEnabled, RefPtr<SourceBufferPrivate>&) = 0;

Nit: the parameter name isn't necessary.

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
69
> +    AddStatus addSourceBuffer(const ContentType&, bool webMParserEnabled,
RefPtr<SourceBufferPrivate>&) override;

Ditto.

> Source/WebCore/platform/graphics/cocoa/SourceBufferParser.h:49
> +    static RefPtr<SourceBufferParser> create(const ContentType&, bool
webMParserEnabled);

Ditto

> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:67
> +MediaSourcePrivate::AddStatus MockMediaSourcePrivate::addSourceBuffer(const
ContentType& contentType, bool webMParserEnabled, RefPtr<SourceBufferPrivate>&
outPrivate)
>  {
> +    UNUSED_PARAM(webMParserEnabled);

Ditto, and you don't need the UNUSED_PARAM without it.

> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.h:82
> +    AddStatus addSourceBuffer(const ContentType&, bool webMParserEnabled,
RefPtr<SourceBufferPrivate>&) override;

Ditto.

> Source/WebKit/GPUProcess/media/RemoteMediaSourceProxy.h:60
> +    RemoteMediaSourceProxy(GPUConnectionToWebProcess&,
RemoteMediaSourceIdentifier, bool webMParserEnabled, RemoteMediaPlayerProxy&);

Ditto.

> Source/WebKit/WebProcess/GPU/media/MediaSourcePrivateRemote.h:65
> +    AddStatus addSourceBuffer(const WebCore::ContentType&, bool
webMParserEnabled, RefPtr<WebCore::SourceBufferPrivate>&) final;

Ditto.