[webkit-reviews] review granted: [Bug 219863] Simplify transform blending for simple cases : [Attachment 416176] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 14 11:20:40 PST 2020


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 219863: Simplify transform blending for simple cases
https://bugs.webkit.org/show_bug.cgi?id=219863

Attachment 416176: Patch

https://bugs.webkit.org/attachment.cgi?id=416176&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 416176
  --> https://bugs.webkit.org/attachment.cgi?id=416176
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416176&action=review

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:952
> +    if (!fmod(angle, 360))

std::fmod or std::fmod<double>

> Source/WebCore/platform/graphics/transforms/TransformationMatrix.cpp:1675
> +	   for (size_t x = 0; x < 4; ++x) {
> +	       for (size_t y = 0; y < 4; ++y)
> +		   m_matrix[x][y] = from.m_matrix[x][y];
> +	   }

You can just do *this = from here.


More information about the webkit-reviews mailing list