[webkit-reviews] review granted: [Bug 219830] Move some of the work from JSLock to VMEntryScope : [Attachment 416129] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 14 10:18:34 PST 2020
Mark Lam <mark.lam at apple.com> has granted Tadeu Zagallo <tzagallo at apple.com>'s
request for review:
Bug 219830: Move some of the work from JSLock to VMEntryScope
https://bugs.webkit.org/show_bug.cgi?id=219830
Attachment 416129: Patch
https://bugs.webkit.org/attachment.cgi?id=416129&action=review
--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 416129
--> https://bugs.webkit.org/attachment.cgi?id=416129
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416129&action=review
r=me
> Source/JavaScriptCore/runtime/JSLock.h:148
> + uint32_t m_lastOwnerThread { 0 };
nit: Not the most important thing but can you swap the position of this with
m_shouldReleaseHeapAccess below. That should pack the fields better.
More information about the webkit-reviews
mailing list