[webkit-reviews] review requested: [Bug 219844] [GTK] Build failures with GTK4 3.99.5.1 : [Attachment 416136] Initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 13 21:00:39 PST 2020


Lauro Moura <lmoura at igalia.com> has asked  for review:
Bug 219844: [GTK] Build failures with GTK4 3.99.5.1
https://bugs.webkit.org/show_bug.cgi?id=219844

Attachment 416136: Initial patch

https://bugs.webkit.org/attachment.cgi?id=416136&action=review




--- Comment #1 from Lauro Moura <lmoura at igalia.com> ---
Created attachment 416136

  --> https://bugs.webkit.org/attachment.cgi?id=416136&action=review

Initial patch

Initial patch with tentative fixes where the build failed. In
`webkitWebViewBaseSizeAllocate` I left the gtk_native_check_resize commented
out as I'm not sure how to proceed with it. The GTK changes replaced it with
explicit calls to the child types. Should WebKitGTK then do something similar
and go through each of the internal children and call the appropiate functions?


More information about the webkit-reviews mailing list