[webkit-reviews] review granted: [Bug 219820] Remove WKDownloadDelegate.didWriteData : [Attachment 416086] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 13 08:37:39 PST 2020

Sam Weinig <sam at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 219820: Remove WKDownloadDelegate.didWriteData

Attachment 416086: Patch


--- Comment #5 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 416086
  --> https://bugs.webkit.org/attachment.cgi?id=416086

View in context: https://bugs.webkit.org/attachment.cgi?id=416086&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKDownload.mm:221
>> +	    downloadProgress = [NSProgress progressWithTotalUnitCount:-1];
> Presumably -1 is a sentinel for undetermined/indeterminate progress? Why was
this 100 originally?

Maybe throwing the -1 into a constant will help clear this up.

More information about the webkit-reviews mailing list