[webkit-reviews] review granted: [Bug 219688] Pass an isolated copy of Settings to workers and worklets. : [Attachment 415763] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted youenn fablet <youennf at gmail.com>'s
request for review:
Bug 219688: Pass an isolated copy of Settings to workers and worklets.
https://bugs.webkit.org/show_bug.cgi?id=219688

Attachment 415763: Patch

https://bugs.webkit.org/attachment.cgi?id=415763&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 415763
  --> https://bugs.webkit.org/attachment.cgi?id=415763
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415763&action=review

This is fantastic work! Thanks Youenn!

> Source/WebCore/ChangeLog:10
> +
> +	   Generate a Settings::Values struct containing all setting values.
> +	   Workers and worklets get that structure from their document and do a
thread safe copy to use it in the background thread.
> +	   Covered by existing tests in workers.

Got a case of the double ChangeLogs.