[webkit-reviews] review granted: [Bug 219759] Enable Metal backend for ANGLE, add non-spirvX compiler path for GLSL to Metal translation : [Attachment 416046] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 219759: Enable Metal backend for ANGLE, add non-spirvX compiler path for
GLSL to Metal translation
https://bugs.webkit.org/show_bug.cgi?id=219759

Attachment 416046: Patch

https://bugs.webkit.org/attachment.cgi?id=416046&action=review




--- Comment #13 from Dean Jackson <dino at apple.com> ---
Comment on attachment 416046
  --> https://bugs.webkit.org/attachment.cgi?id=416046
Patch

Before landing I:

- Fixed the depth texture and other failure
- removed changes.diff
- Put the ANGLE_ENABLE_METAL preprocessor definition in the configuration files
- Reverted the changes to ANGLE's ASSERT
- Reverted the change to the #pragma clang warning