[webkit-reviews] review granted: [Bug 219784] [LFC][IFC] tabCharacter and newlineCharacter are also word separators when not preserved : [Attachment 416055] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 219784: [LFC][IFC] tabCharacter and newlineCharacter are also word
separators when not preserved
https://bugs.webkit.org/show_bug.cgi?id=219784

Attachment 416055: Patch

https://bugs.webkit.org/attachment.cgi?id=416055&action=review




--- Comment #6 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 416055
  --> https://bugs.webkit.org/attachment.cgi?id=416055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416055&action=review

> Source/WebCore/layout/inlineformatting/InlineTextItem.cpp:120
> +		       return text[startPosition] == space
>			   || text[startPosition] == noBreakSpace
>			   || text[startPosition] == ethiopicWordspace
>			   || text[startPosition] == aegeanWordSeparatorLine
>			   || text[startPosition] == aegeanWordSeparatorDot
>			   || text[startPosition] == ugariticWordDivider;

maybe just put the text[startPosition] into a local?