[webkit-reviews] review granted: [Bug 219811] PCM: Add feature flag support in the network process : [Attachment 416064] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 11 16:51:40 PST 2020
Alex Christensen <achristensen at apple.com> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 219811: PCM: Add feature flag support in the network process
https://bugs.webkit.org/show_bug.cgi?id=219811
Attachment 416064: Patch
https://bugs.webkit.org/attachment.cgi?id=416064&action=review
--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 416064
--> https://bugs.webkit.org/attachment.cgi?id=416064
Patch
This is ok, but it might be worth moving to WebsiteDataStoreParameters instead
of NetworkProcessCreationParameters so the boolean can live on the
PrivateClickMeasurementManager instead of NetworkProcess.
More information about the webkit-reviews
mailing list