[webkit-reviews] review granted: [Bug 219803] [webkitscmpy] Load mock repository data from json file : [Attachment 416043] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 11 15:22:36 PST 2020
Stephanie Lewis <slewis at apple.com> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 219803: [webkitscmpy] Load mock repository data from json file
https://bugs.webkit.org/show_bug.cgi?id=219803
Attachment 416043: Patch
https://bugs.webkit.org/attachment.cgi?id=416043&action=review
--- Comment #4 from Stephanie Lewis <slewis at apple.com> ---
Comment on attachment 416043
--> https://bugs.webkit.org/attachment.cgi?id=416043
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416043&action=review
> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py:35
> + self, path='/.invalid-git', data=None,
nit: data to me implies that the file has already been read
More information about the webkit-reviews
mailing list