[webkit-reviews] review granted: [Bug 219732] [Cocoa] Add Experimental VP8 support : [Attachment 416041] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 219732: [Cocoa] Add Experimental VP8 support
https://bugs.webkit.org/show_bug.cgi?id=219732

Attachment 416041: Patch

https://bugs.webkit.org/attachment.cgi?id=416041&action=review




--- Comment #12 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 416041
  --> https://bugs.webkit.org/attachment.cgi?id=416041
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416041&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoderReceiver.cpp:
79
> +    } while (false);

You can use early returns instead of this loop.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoderReceiver.cpp:
102
> +	   auto borderPixelsValue = createNumber(32);

Why not use the `borderPixels` parameter?

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitDecoderReceiver.cpp:
146
> +    OSStatus vtError = kVTVideoDecoderBadDataErr;

Nit: you could set this in a trailing `else` clause