[webkit-reviews] review granted: [Bug 219507] [iOS][FCR] Add new look for select elements : [Attachment 416020] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 11 11:50:33 PST 2020
Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 219507: [iOS][FCR] Add new look for select elements
https://bugs.webkit.org/show_bug.cgi?id=219507
Attachment 416020: Patch
https://bugs.webkit.org/attachment.cgi?id=416020&action=review
--- Comment #13 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 416020
--> https://bugs.webkit.org/attachment.cgi?id=416020
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=416020&action=review
r=mews
> Source/WebCore/rendering/RenderThemeIOS.mm:2388
> + constexpr int size = 18;
Perhaps `length` or `sideLength` instead of `size`? Size more commonly refers
to a { width, height }, especially in this area of code.
More information about the webkit-reviews
mailing list