[webkit-reviews] review granted: [Bug 210071] Trackpad and Mouse scroll events on iPad only fire "pointermove" -- not "wheel" : [Attachment 415975] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 210071: Trackpad and Mouse scroll events on iPad only fire "pointermove" --
not "wheel"
https://bugs.webkit.org/show_bug.cgi?id=210071

Attachment 415975: Patch

https://bugs.webkit.org/attachment.cgi?id=415975&action=review




--- Comment #27 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 415975
  --> https://bugs.webkit.org/attachment.cgi?id=415975
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415975&action=review

> Source/WebKit/ChangeLog:29
> +	   If the event is not preventable, we will synchronously reply that it
was

cancelable

> Source/WebKit/Shared/ios/WebIOSEventFactory.mm:162
> +	   WebKit::WebEvent::Wheel, scrollLocation, scrollLocation, delta, { }
/* wheelTicks */, WebKit::WebWheelEvent::Granularity::ScrollByPixelWheelEvent,
false, toWebPhase(event.phase), WebKit::WebWheelEvent::PhaseNone, true, 1,
delta, { },
MonotonicTime::fromRawSeconds(event.timestamp).approximateWallTime()

I would put this one per line but  ¯\_(ツ)_/¯

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h:232
> +    Optional<bool> _currentScrollGestureWasInitiallyPrevented;

Can this be a Optional<WheelScrollGestureState>?

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:1627
> +	   if (!strongSelf)
> +	       return;

Is it OK to not call the completion handler here?

> Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:1629
> +	   if (isCancelable) {

OK to not call strongCompletion() if not cancelable?