[webkit-reviews] review granted: [Bug 219740] [macOS] Create sandbox extension for AppleAVDUserClient when Media in GPU process is not enabled : [Attachment 415870] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 219740: [macOS] Create sandbox extension for AppleAVDUserClient when Media
in GPU process is not enabled
https://bugs.webkit.org/show_bug.cgi?id=219740

Attachment 415870: Patch

https://bugs.webkit.org/attachment.cgi?id=415870&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 415870
  --> https://bugs.webkit.org/attachment.cgi?id=415870
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415870&action=review

r=me. It's odd that this is apparently needed for Apple Silicon Macs, but isn't
needed in the GPU Process. I'll bet that's a mistake.

> Source/WebKit/UIProcess/WebPageProxy.cpp:7795
> +#if PLATFORM(MAC) && CPU(ARM64)

Is this needed for Catalyst, too? Or does that get picked up by this rule, too?

> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:934
> +	       (iokit-user-client-class "AppleAVDUserClient")

Shouldn't this be listed in the GPU Process sandbox, too?