[webkit-reviews] review granted: [Bug 219705] [GPU Process]: Recording an in-process ImageBuffer drawing has to convert it to a NativeImage first : [Attachment 415795] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 219705: [GPU Process]: Recording an in-process ImageBuffer drawing has to
convert it to a NativeImage first
https://bugs.webkit.org/show_bug.cgi?id=219705

Attachment 415795: Patch

https://bugs.webkit.org/attachment.cgi?id=415795&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 415795
  --> https://bugs.webkit.org/attachment.cgi?id=415795
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415795&action=review

> Source/WebCore/platform/graphics/GraphicsContextImpl.h:42
> +    virtual bool canRecordDrawImageBuffer(const ImageBuffer&) const { return
true; }

It seems like this should just be `canDrawImageBuffer` instead, since it's on
the GraphicsContextImpl (of which DisplayList::Recorder is one particular
implementation).