[webkit-reviews] review denied: [Bug 219600] Support JS type reflections in WebAssembly JS-API : [Attachment 415736] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied jtallon at igalia.com's request for
review:
Bug 219600: Support JS type reflections in WebAssembly JS-API
https://bugs.webkit.org/show_bug.cgi?id=219600

Attachment 415736: Patch

https://bugs.webkit.org/attachment.cgi?id=415736&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 415736
  --> https://bugs.webkit.org/attachment.cgi?id=415736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415736&action=review

Can you update LayoutTests results to make EWS green?
Currently, win, mac-wk1, mac-wk2, and mac-debug-wk1 are red.

> Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp:78
> +	       return throwVMTypeError(globalObject, throwScope,
"WebAssembly.Memory specify exactly one of 'initial' or 'minimum'");

Maybe, "'initial' and 'minimum' options are specified at the same time" would
be better.

> Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp:88
> +	   return throwVMTypeError(globalObject, throwScope, "WebAssembly.Table
exactly one of 'initial' or 'minimum'");

Ditto.