[webkit-reviews] review denied: [Bug 219661] Add runtime flag for ANGLE on Metal : [Attachment 415694] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 08:37:08 PST 2020

Sam Weinig <sam at webkit.org> has denied Dean Jackson <dino at apple.com>'s request
for review:
Bug 219661: Add runtime flag for ANGLE on Metal

Attachment 415694: Patch


--- Comment #3 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 415694
  --> https://bugs.webkit.org/attachment.cgi?id=415694

View in context: https://bugs.webkit.org/attachment.cgi?id=415694&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:99
> +    if (RuntimeEnabledFeatures::sharedFeatures().webGLUsingMetal()) {

This is a layering violation. Code in platform/ is not allowed to use
RuntimeEnabledFeatures as it is not a platform concept.

Instead, the check should be done by the WebCore code that creates this object,
and it should pass down this state.

More information about the webkit-reviews mailing list