[webkit-reviews] review denied: [Bug 219676] Build error after r270457 : [Attachment 415737] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 08:24:36 PST 2020


Chris Dumez <cdumez at apple.com> has denied  review:
Bug 219676: Build error after r270457
https://bugs.webkit.org/show_bug.cgi?id=219676

Attachment 415737: patch

https://bugs.webkit.org/attachment.cgi?id=415737&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 415737
  --> https://bugs.webkit.org/attachment.cgi?id=415737
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415737&action=review

> Source/WebCore/platform/audio/SincResampler.h:51
> +    static const size_t kKernelSize = 32;

See in SincResampler.cpp:
constexpr unsigned kernelSize { 32 };

We should be using kernelSize, not kKernelSize.


More information about the webkit-reviews mailing list