[webkit-reviews] review granted: [Bug 219660] [GPUProcess] Video does not resume if the GPU Process crashes while in fullscreen : [Attachment 415687] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219660: [GPUProcess] Video does not resume if the GPU Process crashes while
in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=219660

Attachment 415687: Patch

https://bugs.webkit.org/attachment.cgi?id=415687&action=review




--- Comment #5 from Darin Adler <darin at apple.com> ---
Comment on attachment 415687
  --> https://bugs.webkit.org/attachment.cgi?id=415687
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415687&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:535
> +    if (client().mediaPlayerFullscreenMode() !=
MediaPlayer::VideoFullscreenModeNone)
> +	   client().mediaPlayerExitFullscreen();

Not sure it’s self explanatory that "we would play in full screen if we could,
but we can’t make that work, so exit full screen to work around that" is the
intention here. Maybe add a brief comment?