[webkit-reviews] review granted: [Bug 219656] TextManipulationController sometimes fails to notify its delegate of new text (if an element has been removed) : [Attachment 415678] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Geoffrey Garen
<ggaren at apple.com>'s request for review:
Bug 219656: TextManipulationController sometimes fails to notify its delegate
of new text (if an element has been removed)
https://bugs.webkit.org/show_bug.cgi?id=219656

Attachment 415678: Patch

https://bugs.webkit.org/attachment.cgi?id=415678&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 415678
  --> https://bugs.webkit.org/attachment.cgi?id=415678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415678&action=review

r=mews

> Source/WebCore/editing/TextManipulationController.cpp:646
> +    if (!m_pendingItemsForCallback.size())

Nit - I think .isEmpty() might read a bit better here.