[webkit-reviews] review granted: [Bug 217216] Implement RemoteGraphicsContextGL : [Attachment 415394] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 217216: Implement RemoteGraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=217216

Attachment 415394: Patch

https://bugs.webkit.org/attachment.cgi?id=415394&action=review




--- Comment #29 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 415394
  --> https://bugs.webkit.org/attachment.cgi?id=415394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415394&action=review

> Source/WebCore/page/Chrome.cpp:553
> +    // TODO: GPU process. Change to GCGLManager, make it work, return null
for others.

Maybe file a bug and reference it here to track the work.

> Source/WebCore/platform/graphics/RemoteGraphicsContextGLProxyBase.cpp:48
> +void RemoteGraphicsContextGLProxyBase::setContextVisibility(bool)
> +{
> +}

Should these implementations ASSERT_NOT_REACHED?

>
Source/WebCore/platform/graphics/cocoa/GraphicsContextGLIOSurfaceSwapChain.h:49
> +	   void* handle { nullptr }; // Producer specific metadata handle (such
as EGLSurface).

It's unclear what the ownership model is for this handle.

> Source/WebKit/WebProcess/GPU/graphics/RemoteGraphicsContextGLProxy.h:379
> +    GraphicsContextGLIdentifier m_graphicsContextGLIdentifier {
GraphicsContextGLIdentifier::generate() };

This object identifier does not guarantee uniqueness between WebContent
processes, but it must.