[webkit-reviews] review granted: [Bug 219487] IPC should support non-byte aligned data references : [Attachment 415294] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 219487: IPC should support non-byte aligned data references
https://bugs.webkit.org/show_bug.cgi?id=219487

Attachment 415294: Patch

https://bugs.webkit.org/attachment.cgi?id=415294&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 415294
  --> https://bugs.webkit.org/attachment.cgi?id=415294
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415294&action=review

r=me with nits.

> Source/WebKit/ChangeLog:10
> +	   size is determined run-time.

*at* run-time

> Source/WebKit/ChangeLog:17
> +	   DataReference or ArrayReference, as a synchronized call return
value.

synchronized -> synchronous IPC

> Source/WebKit/GPUProcess/media/RemoteMediaResourceManager.h:33
> +

I don't think we usually use a blank line in such cases.

> Source/WebKit/GPUProcess/media/RemoteSourceBufferProxy.h:34
> +

ditto.

> Source/WebKit/GPUProcess/webrtc/LibWebRTCCodecsProxy.h:34
> +

ditto.

> Source/WebKit/Platform/IPC/ArrayReference.h:2
> + * Copyright (C) 2010 Apple Inc. All rights reserved.

2010-2020

>> Source/WebKit/Platform/IPC/ArrayReference.h:76
>> +	size_t m_size { };
> 
> const T* m_data { nullptr };
> size_t m_size { 0 };

Agreed.

>> Source/WebKit/Platform/IPC/ArrayReference.h:117
>> +	const T* m_data { };
> 
> const T* m_data { nullptr };

Agreed.

> Source/WebKit/WebProcess/Inspector/WebInspectorUIExtensionController.cpp:43
> +    WebCore::Page* page = inspectorFrontend.frontendPage();

auto*