[webkit-reviews] review denied: [Bug 219647] Make ScrollingPerformanceLoggingEnabled an internal debug preference : [Attachment 415654] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 8 11:01:00 PST 2020


Sam Weinig <sam at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 219647: Make ScrollingPerformanceLoggingEnabled an internal debug
preference
https://bugs.webkit.org/show_bug.cgi?id=219647

Attachment 415654: Patch

https://bugs.webkit.org/attachment.cgi?id=415654&action=review




--- Comment #2 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 415654
  --> https://bugs.webkit.org/attachment.cgi?id=415654
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415654&action=review

> Source/WebCore/page/Settings.yaml:158
> +ForceUpdateScrollbarsOnMainThreadForPerformanceTesting:
> +  type: bool
> +  defaultValue:
> +    WebCore:
> +	 default: false

Please don't add this here. I have been removing things from this file and
moving them to WebPreferences.yaml with the goal of removing this file soon.


More information about the webkit-reviews mailing list