[webkit-reviews] review canceled: [Bug 219622] [Media in GPU Process][MSE] The GPU Process may crash in the destructor of MediaPlayerPrivateMediaSourceAVFObjC : [Attachment 415604] Patch

[bugzilla-daemon at webkit.org]

Peng Liu <peng.liu6 at apple.com> has canceled Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 219622: [Media in GPU Process][MSE] The GPU Process may crash in the
destructor of MediaPlayerPrivateMediaSourceAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=219622

Attachment 415604: Patch

https://bugs.webkit.org/attachment.cgi?id=415604&action=review




--- Comment #3 from Peng Liu <peng.liu6 at apple.com> ---
Comment on attachment 415604
  --> https://bugs.webkit.org/attachment.cgi?id=415604
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415604&action=review

>> Source/WebKit/GPUProcess/media/cocoa/RemoteMediaPlayerProxyCocoa.mm:-60
>> -	m_inlineLayerHostingContext->setRootLayer(m_player->platformLayer());
> 
> It is not clear why removing this line is fine.
> Is it redundant? If so, can you add this info in change log?

The purpose of this callback is to notify the DOM that the player's rendering
mode is changed, including the case that the layer is destroyed. So I think it
was a bug to operate on the layer.
I just realized that we need to forward the callback to the Web process
(HTMLMediaElement). I will upload a new patch.