[webkit-reviews] review denied: [Bug 219600] Support JS type reflections in WebAssembly JS-API : [Attachment 415554] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has denied jtallon at igalia.com's request for
review:
Bug 219600: Support JS type reflections in WebAssembly JS-API
https://bugs.webkit.org/show_bug.cgi?id=219600

Attachment 415554: Patch

https://bugs.webkit.org/attachment.cgi?id=415554&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 415554
  --> https://bugs.webkit.org/attachment.cgi?id=415554
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415554&action=review

Looks good, but put r- since I found bugs, And, can you update the LayoutTests
results to make EWS green?

> Source/JavaScriptCore/wasm/js/WebAssemblyMemoryConstructor.cpp:74
> +	   JSValue minSizeValue = memoryDescriptor->get(globalObject, minimum);

We need

RETURN_IF_EXCEPTION(throwScope, encodedJSValue());

here since `->get(...)` can throw an error.

> Source/JavaScriptCore/wasm/js/WebAssemblyTableConstructor.cpp:85
> +    JSValue minSizeValue = memoryDescriptor->get(globalObject,
minimumIdent);

Ditto.