[webkit-reviews] review granted: [Bug 219527] Align %TypedArray% constructor behavior with spec : [Attachment 415594] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 219527: Align %TypedArray% constructor behavior with spec
https://bugs.webkit.org/show_bug.cgi?id=219527

Attachment 415594: Patch

https://bugs.webkit.org/attachment.cgi?id=415594&action=review




--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 415594
  --> https://bugs.webkit.org/attachment.cgi?id=415594
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415594&action=review

Nice, r=me

> Source/JavaScriptCore/runtime/JSArrayBufferPrototype.cpp:68
> +    VM& vm = globalObject->vm();
> +    auto scope = DECLARE_THROW_SCOPE(vm);
> +
> +    bool isValid = speciesWatchpointIsValid(vm, thisObject, mode);
> +    scope.assertNoException();
> +    if (LIKELY(isValid))
> +	   return WTF::nullopt;
> +

Can you make this part inlined when the caller is calling this? (like,
definition it in JSArrayBufferPrototypeInlines.h)
I think 99.9999999% of path will go to this "watchpoint is valid" case. So it
is worth inlining.