[webkit-reviews] review granted: [Bug 219620] Potential crash under [WKRemoteObjectEncoder encodeObject:forKey:] when the object graph contains a cycle : [Attachment 415598] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219620: Potential crash under [WKRemoteObjectEncoder encodeObject:forKey:]
when the object graph contains a cycle
https://bugs.webkit.org/show_bug.cgi?id=219620

Attachment 415598: Patch

https://bugs.webkit.org/attachment.cgi?id=415598&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 415598
  --> https://bugs.webkit.org/attachment.cgi?id=415598
Patch

r=me

Seems OK, but aren't we just going to keep crashing? (NSException is fatal.)

Maybe a better behavior would be to log an error and skip the recursion.