[webkit-reviews] review granted: [Bug 219616] [ESNext] op_put_private_name is wrong : [Attachment 415590] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 7 15:09:47 PST 2020


Tadeu Zagallo <tzagallo at apple.com> has granted Caio Lima
<ticaiolima at gmail.com>'s request for review:
Bug 219616: [ESNext] op_put_private_name is wrong
https://bugs.webkit.org/show_bug.cgi?id=219616

Attachment 415590: Patch

https://bugs.webkit.org/attachment.cgi?id=415590&action=review




--- Comment #2 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 415590
  --> https://bugs.webkit.org/attachment.cgi?id=415590
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415590&action=review

r=me with a small nit

> Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:1796
> +    bqneq t3, t1, .opPutPrivateNameSlow

Should't this be a `bpneq`?


More information about the webkit-reviews mailing list