[webkit-reviews] review granted: [Bug 219612] Parse content after # in data URLs with HLS mime types : [Attachment 415588] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 7 14:55:50 PST 2020


Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 219612: Parse content after # in data URLs with HLS mime types
https://bugs.webkit.org/show_bug.cgi?id=219612

Attachment 415588: Patch

https://bugs.webkit.org/attachment.cgi?id=415588&action=review




--- Comment #10 from Darin Adler <darin at apple.com> ---
Comment on attachment 415588
  --> https://bugs.webkit.org/attachment.cgi?id=415588
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415588&action=review

> Source/WebCore/platform/network/DataURLDecoder.cpp:58
> +    return !equalIgnoringASCIICase(mediaType, "video/mpegurl")
> +	   && !equalIgnoringASCIICase(mediaType, "audio/mpegurl")
> +	   && !equalIgnoringASCIICase(mediaType, "application/x-mpegurl")
> +	   && !equalIgnoringASCIICase(mediaType, "vnd.apple.mpegurl");

This lowercases things as required by equalLettersIgnoringASCIICase, but didn’t
add the word "Letters" to the function name.


More information about the webkit-reviews mailing list