[webkit-reviews] review granted: [Bug 219612] Parse content after # in data URLs with HLS mime types : [Attachment 415576] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 7 13:47:24 PST 2020
Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 219612: Parse content after # in data URLs with HLS mime types
https://bugs.webkit.org/show_bug.cgi?id=219612
Attachment 415576: Patch
https://bugs.webkit.org/attachment.cgi?id=415576&action=review
--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 415576
--> https://bugs.webkit.org/attachment.cgi?id=415576
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=415576&action=review
> Source/WebCore/platform/network/DataURLDecoder.cpp:48
> +static bool shouldRemoveFragmentIdentifier(const String& mediaType)
I’d like to see a "why" comment mentioning the reason for the MIME type special
cases here.
Also wondering if we will keep this forever.
> Source/WebCore/platform/network/DataURLDecoder.cpp:55
> + return !equalIgnoringASCIICase(mediaType, "video/mpegURL")
> + && !equalIgnoringASCIICase(mediaType, "audio/mpegURL");
This could instead be written in this slightly more efficient way:
return !equalLettersIgnoringASCIICase(mediaType, "video/mpegurl")
&& !equalLettersIgnoringASCIICase(mediaType, "audio/mpegurl");
> Source/WebCore/platform/network/DataURLDecoder.cpp:127
> - const String urlString;
> + URL url;
This is a much bigger object. Is that OK?
More information about the webkit-reviews
mailing list