[webkit-reviews] review granted: [Bug 219576] [JSC] get / set for object literal and class should not be escaped : [Attachment 415513] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 219576: [JSC] get / set for object literal and class should not be escaped
https://bugs.webkit.org/show_bug.cgi?id=219576

Attachment 415513: Patch

https://bugs.webkit.org/attachment.cgi?id=415513&action=review




--- Comment #2 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 415513
  --> https://bugs.webkit.org/attachment.cgi?id=415513
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415513&action=review

Marvelous, r=me!

> Source/JavaScriptCore/ChangeLog:8
> +	   "get" and "set" for getter and setter should not be escaped one.

Perhaps it's worth to explain why not, in contrast to previous patch? Like:

	Terminal symbols of the lexical grammars are shown in fixed width font
[1], and are to appear in a script exactly as written.

	[1]: https://tc39.es/ecma262/#sec-method-definitions