[webkit-reviews] review granted: [Bug 219575] [JSC] Accept escaped keywords for class and object property names : [Attachment 415511] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 219575: [JSC] Accept escaped keywords for class and object property names
https://bugs.webkit.org/show_bug.cgi?id=219575

Attachment 415511: Patch

https://bugs.webkit.org/attachment.cgi?id=415511&action=review




--- Comment #3 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 415511
  --> https://bugs.webkit.org/attachment.cgi?id=415511
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415511&action=review

Great job on this very neat change! r=me with a question.

> Source/JavaScriptCore/parser/ParserTokens.h:197
> +    INVALID_TEMPLATE_LITERAL_ERRORTOK = 15 | CanBeErrorTokenFlag,

While introducing CanBeErrorTokenFlag for ESCAPED_KEYWORD makes perfect sense,
perhaps we should leave more strict ErrorTokenFlag for other types that are
definitely syntax errors?