[webkit-reviews] review granted: [Bug 219551] Remove ENABLE_GRAPHICS_CONTEXT_GL by replacing it with ENABLE(WEBGL) : [Attachment 415451] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 4 18:16:15 PST 2020
Kenneth Russell <kbr at google.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 219551: Remove ENABLE_GRAPHICS_CONTEXT_GL by replacing it with
ENABLE(WEBGL)
https://bugs.webkit.org/show_bug.cgi?id=219551
Attachment 415451: Patch
https://bugs.webkit.org/attachment.cgi?id=415451&action=review
--- Comment #3 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 415451
--> https://bugs.webkit.org/attachment.cgi?id=415451
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=415451&action=review
Looks like a nice cleanup. As long as this builds everywhere, r+.
> Source/WebCore/platform/graphics/GLContext.cpp:21
> +#if USE(OPENGL) || USE(OPENGL_ES)
Wasn't immediately obvious to me that these two #if statements are functionally
equivalent.
> Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.cpp:438
> +#endif // ENABLE(WEBGL) && || !USE(ANGLE)
Typo - please fix.
More information about the webkit-reviews
mailing list