[webkit-reviews] review granted: [Bug 219560] Simplify audio resampling code : [Attachment 415474] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 219560: Simplify audio resampling code
https://bugs.webkit.org/show_bug.cgi?id=219560

Attachment 415474: Patch

https://bugs.webkit.org/attachment.cgi?id=415474&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 415474
  --> https://bugs.webkit.org/attachment.cgi?id=415474
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415474&action=review

> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:124
> +    if (AudioSourceProvider* provider =
mediaElement().audioSourceProvider())

I would've used auto here. And I noticed you did use it in a similar case
below.

> Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp:172
> +    if (m_multiChannelResampler.get()) {

I don’t think "get()" is needed here.