[webkit-reviews] review granted: [Bug 219558] [GPU Process] Rename imageBuffer::flushDrawingContextAndCommit() to commitDrawingContext() : [Attachment 415468] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Said Abou-Hallawa
<sabouhallawa at apple.com>'s request for review:
Bug 219558: [GPU Process] Rename imageBuffer::flushDrawingContextAndCommit() to
commitDrawingContext()
https://bugs.webkit.org/show_bug.cgi?id=219558

Attachment 415468: Patch

https://bugs.webkit.org/attachment.cgi?id=415468&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 415468
  --> https://bugs.webkit.org/attachment.cgi?id=415468
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=415468&action=review

Regardless of which way you go, this is better than the current name.

> Source/WebCore/platform/graphics/ImageBuffer.h:82
> +    virtual void commitDrawingContext() { }
>      virtual void submitDisplayList(const DisplayList::DisplayList&) { }

should we go with submit, like submitDisplayList? That is what this is, right?
Submit outstanding pending work? There's no synchronization here, so not sure
about the "commit" word.